Skip to content

usage: use runtime scope when running maven usage profile #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pearl1594 merged 1 commit into from
Feb 18, 2025
Merged

usage: use runtime scope when running maven usage profile #10331

Pearl1594 merged 1 commit into from
Feb 18, 2025

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Feb 6, 2025 •
edited
Loading

Fixes error running usage server with maven.

Description

This PR fixes running usage server with maven:

mvn -P usage -Drun -Dpid=$$ -pl usage

Above command fails to bring up usage server and errors out as shown in following screenshot
Screenshot from 2025-02-06 11-10-17

Failure is related to JDBC driver not being available
48.405 [com.cloud.usage.UsageServer.main()] ERROR com.cloud.utils.db.DriverLoader - Failed to load DB driver com.mysql.cj.jdbc.Driver

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Re-run the usage server with mvn and it executes without any issue.

How did you try to break this feature and the system with this change?

@shwstppr
usage: use runtime scope when running maven usage profile
b615fdc 
Fixes error running usage server with maven.

Signed-off-by: Abhishek Kumar <[email protected]>
@codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.23%. Comparing base (986ec81) to head (b615fdc).
Report is 34 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10331      +/-   ##
============================================
+ Coverage     16.00%   16.23%   +0.23%     
- Complexity    13065    13507     +442     
============================================
  Files          5644     5671      +27     
  Lines        494870   508387   +13517     
  Branches      59949    64260    +4311     
============================================
+ Hits          79195    82539    +3344     
- Misses       406838   416770    +9932     
- Partials       8837     9078     +241
Flag Coverage Δ
uitests 4.04% <ø> (+0.02%) ⬆️
unittests 17.08% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sudo87 sudo87 changed the base branch from main to 4.20 February 7, 2025 04:15
@shwstppr shwstppr closed this Feb 7, 2025
@shwstppr shwstppr reopened this Feb 7, 2025
DaanHoogland
DaanHoogland approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, I don't think smoke test suite will help testing this so needs a manual verification.

@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Feb 7, 2025
@blueorangutan
Copy link

blueorangutan commented Feb 7, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12374

@Pearl1594
Copy link
Contributor

Pearl1594 commented Feb 14, 2025

I wonder how it worked all this while..

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 15, 2025

tested locally

# mvn clean install -P developer,systemvm -Dnoredist -Dsimulator
# mvn -Pdeveloper -pl developer -Ddeploydb
# mvn -Pdeveloper -pl developer -Ddeploydb-simulator
# mvn -pl client jetty:run -Dsimulator
# mvn -P usage -Drun -Dpid=$$ -pl usage

it works.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 15, 2025 •
edited
Loading

I wonder how it worked all this while..

@Pearl1594 , the usage server is not usually tested in a simulator/maven run. It is normally, even for testing, installed as a regular process.

i.e. it never did

@Pearl1594 Pearl1594 merged commit c121d5b into apache:4.20 Feb 18, 2025
46 of 48 checks passed
@Pearl1594 Pearl1594 deleted the fix-usage-mvn branch February 18, 2025 14:21
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@sudo87 @shwstppr @dhslove
usage: use runtime scope when running maven usage profile (apache#10331)
2a776c1 
Fixes error running usage server with maven.

Signed-off-by: Abhishek Kumar <[email protected]>
Co-authored-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:build component:usage-server

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@sudo87 @blueorangutan @Pearl1594 @DaanHoogland @shwstppr